ETQ instructeur si j'utilise un filtre de type choix, les valeurs possibles s'affichent dans un select #9560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisa-durand
force-pushed
the
instructeur-filter-display-select-for-multiple-field
branch
2 times, most recently
from
d00c532 to
99199e9
Compare
lisa-durand
force-pushed
the
instructeur-filter-display-select-for-multiple-field
branch
from
99199e9 to
cde8c61
Compare
tchak
reviewed
Oct 9, 2023
app/models/type_de_champ.rb
Outdated
| @@ -462,7 +480,7 @@ def current_section_level(revision) | |||
| end | |||
|
|
|||
| def self.filter_hash_type(type_champ) | |||
| if type_champ.in?([TypeDeChamp.type_champs.fetch(:departements), TypeDeChamp.type_champs.fetch(:regions)]) | |||
| if type_champ.in?([TypeDeChamp.type_champs.fetch(:departements), TypeDeChamp.type_champs.fetch(:regions)]) || is_choice_type_from(type_champ) | |||
There was a problem hiding this comment.
J'ai l'impression qu'on peut déclarer departements et regions comme choice type, non ?
There was a problem hiding this comment.
Le "type" est utilisé pour organiser les champs dans la création du formulaire, j'ai donc pas touché aux catégories. "Region" et department" sont rangés dans le type "localisation". Du coup je ne sais pas si c'est un bon nommage ou une bonne idée que de les ajouter dans cette methode de type "choix" ?
There was a problem hiding this comment.
Je crois qu'on ne parle pas de la même chose. Je parle de la méthode que tu viens d'ajouter choice_type.
tchak
reviewed
Oct 11, 2023
tchak
reviewed
Oct 11, 2023
tchak
reviewed
Oct 11, 2023
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
tchak
approved these changes
Oct 11, 2023
lisa-durand
deleted the
instructeur-filter-display-select-for-multiple-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9515
On affiche dorénavant un
<select>avec les options proposées, plutôt qu'un champ libre pour les champs de type "choix".